Skip to content

Remove notion of v1 and v2 discovery services #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jan 14, 2025
Merged

Remove notion of v1 and v2 discovery services #1994

merged 20 commits into from
Jan 14, 2025

Conversation

@jackwaudby
Copy link
Contributor

@jackwaudby jackwaudby commented Nov 28, 2024

Removes all mention of v1 and v2 discovery services. We update all configurations and setup guides to reflect there is now one discovery service with 2 settings:

  • dbms.cluster.endpoints
  • dbms.cluster.discovery.resolver_type

@NataliaIvakina NataliaIvakina self-assigned this Nov 28, 2024
@jackwaudby jackwaudby force-pushed the 2024-12-one-discovery-service branch from 990dbbc to 01eda91 Compare December 10, 2024 13:48
@NataliaIvakina NataliaIvakina mentioned this pull request Dec 23, 2024
Merged
jackwaudby
jackwaudby commented Dec 23, 2024
View reviewed changes
nick-giles-neo
nick-giles-neo reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@nick-giles-neo nick-giles-neo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed dbms.kubernetes.service_port_name still referenced.

nick-giles-neo
nick-giles-neo reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@nick-giles-neo nick-giles-neo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And dbms.kubernetes.discovery.v2.service_port_name is still in configuration-settings.adoc, and I think just needs removing.

@NataliaIvakina
Copy link
Collaborator

NataliaIvakina commented Jan 13, 2025 •
edited
Loading

@jackwaudby, @nick-giles-neo, I found two more pages that need to be freed from mentioning discovery services v2 or v1:

  • modules/ROOT/pages/configuration/ports.adoc
  • modules/ROOT/pages/security/ssl-framework.adoc

Could you please take a look at them?

@jackwaudby
Copy link
Contributor Author

jackwaudby commented Jan 13, 2025

@NataliaIvakina I've removed mentions of v1/v2 from those pages. In ssl-framework.adoc I came across other mentions of 5.x versions, I haven't removed them bu I guess they might need removing as well?

NataliaIvakina
NataliaIvakina reviewed Jan 14, 2025
View reviewed changes
NataliaIvakina
NataliaIvakina reviewed Jan 14, 2025
View reviewed changes
@NataliaIvakina
Copy link
Collaborator

NataliaIvakina commented Jan 14, 2025

In ssl-framework.adoc I came across other mentions of 5.x versions, I haven't removed them bu I guess they might need removing as well?

@jackwaudby, you're right, but let's do it in another PR.

NataliaIvakina
NataliaIvakina approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@NataliaIvakina NataliaIvakina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Test failures will be resolved in other PRs.
@nick-giles-neo, any comments?

NataliaIvakina
NataliaIvakina reviewed Jan 14, 2025
View reviewed changes
NataliaIvakina
NataliaIvakina reviewed Jan 14, 2025
View reviewed changes
NataliaIvakina
NataliaIvakina reviewed Jan 14, 2025
View reviewed changes
@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Jan 14, 2025 •
edited
Loading

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@nick-giles-neo
Copy link
Contributor

nick-giles-neo commented Jan 14, 2025

Looks good! Test failures will be resolved in other PRs. @nick-giles-neo, any comments?

I'm happy!

@NataliaIvakina NataliaIvakina merged commit 75f26f2 into neo4j:dev Jan 14, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NataliaIvakina NataliaIvakina NataliaIvakina approved these changes

@nick-giles-neo nick-giles-neo nick-giles-neo left review comments

Assignees

@NataliaIvakina NataliaIvakina

Labels

2025.01 dev

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jackwaudby @NataliaIvakina @neo-technology-commit-status-publisher @nick-giles-neo